chore: update contributing guidelines, improve environment setup, and refactor search functionality #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftonato
commented
Dec 11, 2024
ftonato
commented
- Enhanced the CONTRIBUTING.md file for clarity on environment variable setup and installation instructions.
- Updated package.json to use npx for prettier formatting.
- Refactored search functionality to implement a provider pattern for different search engines, including Google, Serper, and SearchAPI.
- Removed deprecated Google search implementation and related files.
- Improved error handling and logging in search functions.
- Added tests for the new Google search result parser.
- Introduced a new provider factory to streamline search provider creation.
… refactor search functionality - Enhanced the CONTRIBUTING.md file for clarity on environment variable setup and installation instructions. - Updated package.json to use npx for prettier formatting. - Refactored search functionality to implement a provider pattern for different search engines, including Google, Serper, and SearchAPI. - Removed deprecated Google search implementation and related files. - Improved error handling and logging in search functions. - Added tests for the new Google search result parser. - Introduced a new provider factory to streamline search provider creation.
This reverts commit 748fd4b.
|
This is awesome @ftonato! Thank you! You just reminded me that we had to fix our prettier settings. |
nickscamara
reviewed
Dec 11, 2024
There was a problem hiding this comment.
No need for this anymore, added prettier as dependency
There was a problem hiding this comment.
I would say we can keep it here, as it will be removed once we merge #969.
Unless you insist that this should be removed in this PR, I can easily do it anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.