Custom launch url function #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxdocobxx
commented
May 14, 2019
xxdocobxx
commented
- Added the parameter onLaunchUrl to ZefyrEditor and ZefyrView.
- Implemented launchUrl on ZefyrView.
- Added the parameter horizontalRuleColor to ZefyrThemeData. - Added the parameter backgroundColor to quote and code BlockTheme
This reverts commit f63fe3a.
- Added the parameter onLaunchUrl to ZefyrEditor and ZefyrView. - Impletemented launchUrl on ZefyrView.
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 92.11% 93.22% +1.11%
==========================================
Files 12 12
Lines 1090 1077 -13
==========================================
Hits 1004 1004
+ Misses 86 73 -13
Continue to review full report at Codecov.
|
xxdocobxx
commented
May 17, 2019
| children = widget.node.children | ||
| .map((node) => _segmentToTextSpanView(node, theme)) | ||
| .toList(growable: true); | ||
| children.add(TextSpan(text: ' ', style: TextStyle(fontSize: 1.0))); |
There was a problem hiding this comment.
Add a small space at the end of each line in view mode to prevent the tail empty part from being tappable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.