Requested changes to testnet4 faucet UI #5091

mononaut · 2024-05-21T01:10:20Z

This PR makes some minor changes to the faucet UI:

s/"to limit abuse"/"to use the faucet"/.
only disable the submit button instead of graying out the whole form.
set dummy min/max values until/unless the user's limits are available.
minor refactor of the form initialization (just update the validators, instead of the whole formGroup, when possible).
refresh the faucet status after a successful payout, to keep the user's limits up to date.
support displaying both the last success banner and a current error (e.g. after the user's last permitted withdrawal).
properly validate amounts set via the quick buttons.

Screen.Recording.2024-05-21.at.12.36.23.AM.mov

Screen.Recording.2024-05-21.at.12.45.07.AM.mov

frontend/src/app/components/faucet/faucet.component.ts

nymkappa

Tested ACK @ 6bb2f06

Minor faucet UI refactor

35ff2c7

mononaut requested review from wiz and nymkappa May 21, 2024 01:10

cla-bot bot added the cla-signed label May 21, 2024

nymkappa requested changes May 21, 2024

View reviewed changes

frontend/src/app/components/faucet/faucet.component.ts Show resolved Hide resolved

Update default faucet min, revalidate on change

e5ab8ab

mononaut requested a review from nymkappa May 21, 2024 22:13

Faucet: clamp default amount to minimum

6bb2f06

nymkappa approved these changes May 23, 2024

View reviewed changes

softsimon merged commit 2341b1d into master May 23, 2024
13 checks passed

softsimon deleted the mononaut/faucet-ui-changes branch May 23, 2024 12:11

Provide feedback