Fix block animations while syncing #3651
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A question regarding the "Backend syncing" part. It seems the blocks will now flow from left to right even though the mempool is not matching with null as match rate? Before we just popped them up to the right side and only animate over when there is a match in the mempool and mined blocks. Here I started the backend after being offline for a few hours and blocks were animating, despite the mempool basically not changing. Not sure what's right and wrong here.
|
|
Good point, we shouldn't animate the latest mined block in that case. I'll fix it. |
softsimon
requested changes
May 14, 2023
|
@knorrium isn't this old PR fixing your thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues with the blockchain animations while the backend is syncing (e.g. after a fresh install, or being offline for a time), and also during bitcoin core initial block download.
IBD
Before:
long-before.mp4
After:
long-after.mp4
Backend syncing
Before:
before.mp4
After:
after.mp4