Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the external module for SAML SSO #2049

Open
wants to merge 12 commits into
base: sso-saml-module
Choose a base branch
from

Conversation

antepusic
Copy link
Contributor

@antepusic antepusic commented May 20, 2024

Description

This PR adds an external module that enables SAML single sign-on by validating SAML responses. The supported identity providers are Microsoft Entra ID and Okta.

NB: Auth stack extensions have been made in #1990.

[master < Task] PR

  • Write E2E tests
  • Provide the full content or a guide for the final git message
    • [FINAL GIT MESSAGE]

CI Testing Labels

Please select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [Release note text]
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

@antepusic antepusic added feature feature enterprise Docs needed Docs needed CI -build=release -test=e2e Run release build and e2e tests on push labels May 20, 2024
@antepusic antepusic self-assigned this May 20, 2024
src/auth/reference_modules/saml.py Outdated Show resolved Hide resolved
src/auth/reference_modules/saml.py Show resolved Hide resolved
@antepusic antepusic requested a review from imilinovic May 20, 2024 08:52
Copy link
Contributor

@imilinovic imilinovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now but I am not 100% familiar with saml standards.

import json
import os

from onelogin.saml2.auth import OneLogin_Saml2_Auth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add requirements.txt under src/auth/reference_modules/ + install it during memgraph install, update documentation, how users should install all deps required to run reference modules.

@antepusic antepusic added this to the mg-v2.18.0 milestone May 20, 2024
@antepusic antepusic mentioned this pull request May 21, 2024
10 tasks
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI -build=release -test=e2e Run release build and e2e tests on push Docs needed Docs needed enterprise feature feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants