Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Enum datatype #2039

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from
Draft

[Feature] Enum datatype #2039

wants to merge 27 commits into from

Conversation

Ignition
Copy link
Contributor

@Ignition Ignition commented May 14, 2024 •
edited

Description

Introduce the Enum datatype to the CYPHER query.

  • Compact representation for a finite set of members
  • Semantically more meaningful than ints
  • More performant than string comparisons

part of #2042

[master < Epic] PR

  • Write E2E tests
  • Compare the benchmarking results between the master branch and the Epic branch
  • Provide the full content or a guide for the final git message
    • [FINAL GIT MESSAGE]

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [Release note text]
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

@Ignition Ignition added feature feature Docs needed Docs needed labels May 14, 2024
@Ignition Ignition added this to the mg-v2.17.0 milestone May 14, 2024
@Ignition Ignition force-pushed the enum branch 5 times, most recently from 579b735 to 49d3184 Compare May 17, 2024 12:18
@gitbuda gitbuda modified the milestones: mg-v2.17.0, mg-v2.18.0 May 20, 2024
@Ignition Ignition force-pushed the enum branch 4 times, most recently from 26044f4 to 0862b3c Compare May 21, 2024 11:41
@Ignition
Copy link
Contributor Author

@MarkoBarisic Can you add https://github.com/rollbear/strong_type.git to out cache?

@Ignition Ignition force-pushed the enum branch 3 times, most recently from b30e4a5 to d8a08ab Compare May 23, 2024 12:45
@Ignition Ignition linked an issue May 23, 2024 that may be closed by this pull request
[EPIC] Enum feature #2042
Open
12 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
19.6% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ignition Ignition

@Darych Darych

Labels
Docs needed Docs needed feature feature
Projects
None yet
Milestone
mg-v2.18.0
Development

Successfully merging this pull request may close these issues.

[EPIC] Enum feature
3 participants
@Ignition @Darych @gitbuda