Limit number of hops #1928
Open
Limit number of hops #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b074827.
DavIvek
force-pushed
the
limit-number-of-hops
branch
from
f13a057
to
b074827
Compare
This reverts commit 0bb0363.
Darych
reviewed
May 29, 2024
Josipmrden
reviewed
Jun 3, 2024
| int64_t expanded_count = 0; | ||
| const auto &edges = direction == EdgeDirection::IN ? vertex_->in_edges : vertex_->out_edges; | ||
| if (hops_limit && hops_limit->IsUsed()) { | ||
| if (hops_limit->LeftHops() == 0 && static_cast<int64_t>(edges.size()) > 0) { |
There was a problem hiding this comment.
can this ever be < 0 and fool the condition?
There was a problem hiding this comment.
since we can increment by more than 1
There was a problem hiding this comment.
If everything is correct in the operators, this should not happen. That would mean that the limit has already been reached and we shouldn't end up in the vertex accessor, instead part of the query where expansions are done should have ended.
|
Darych
reviewed
Jun 12, 2024
| @@ -35,6 +35,13 @@ class VertexAccessor final { | |||
| private: | |||
| friend class Storage; | |||
|
|
|||
| int64_t HandleExpansionsWithoutEdgeTypes(edge_store &edges, query::HopsLimit *hops_limit, | |||
There was a problem hiding this comment.
Let's rename edges to result_edges to be in sync with implementation and emphasize that this is returned value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Syntax:
USING HOPS LIMIT xPR for hops counting: #1935.
Count (Measure and expose hops back to the user (BFS+DFS+Expand; if an edge is filtered out, it should count as a hop).
How to count hops → each time an edge is “crossed”, it’s counted as a HOP.
NOTE: Different cursor will return different paths due to different implementations. Hops are counted in the same way for every cursor.
[master < Task] PR
Documentation checklist
closes #1374