Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Inverting bool value in rust #447

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

andrejtonev
Copy link

@andrejtonev andrejtonev commented Feb 27, 2024

Description

When executing rust procedures, any boolean arguments get negated.

Pull request type

  • Bugfix

Related issues

#426

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@andrejtonev andrejtonev self-assigned this Feb 27, 2024
@andrejtonev andrejtonev added type: bug Something isn't working and removed type: bug Something isn't working labels Feb 27, 2024
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@andrejtonev andrejtonev added Docs - changelog only Docs - changelog only bug bug labels Feb 29, 2024
@andrejtonev
Copy link
Author

@kgolubic
Changelog: Rust bool value conversion fixed.

@Ignition
Copy link
Collaborator

Ignition commented Mar 7, 2024

Maybe add a test to rust/rsmgp-sys/src/value/tests.rs

Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kgolubic
Copy link

kgolubic commented Apr 3, 2024

@andrejtonev the milestone is missing. Can you please set it?

@andrejtonev
Copy link
Author

@kgolubic mage does not follow the same workflow as memgraph. No milestone is defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug Docs - changelog only Docs - changelog only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants