Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memgraph 2.18.1 #5

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Memgraph 2.18.1 #5

merged 4 commits into from
Jul 23, 2024

Conversation

as51340
Copy link
Contributor

@as51340 as51340 commented Jul 22, 2024 •
edited
Loading

  • Added pre-commit hook.
  • Pushed new version (0.0.3) of operator to DockerHub with changes relevant to 2.18.1.
  • Separated namespace creation into a separate yaml file.
  • Improved installation procedure by using envsubst
  • Updated sample file with changes for 2.18.1:
    • coordinators started with mgmt flag
    • added log files
    • added pvcs

@as51340 as51340 self-assigned this Jul 22, 2024
@as51340 as51340 marked this pull request as ready for review July 22, 2024 10:21
@as51340 as51340 requested a review from antejavor July 22, 2024 10:22
antejavor
antejavor approved these changes Jul 22, 2024
View reviewed changes
Copy link

@antejavor antejavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just take a look at the pre-commit hook, it failed. As with the charts, maybe we should start looking into adding tests for this, to avoid running everything manually, but another place and PR.

@as51340 as51340 force-pushed the memgraph-2.18.1 branch 2 times, most recently from 651216b to fc08dd0 Compare July 23, 2024 11:40
@as51340 as51340 merged commit ad1f426 into main Jul 23, 2024
2 checks passed
@as51340 as51340 deleted the memgraph-2.18.1 branch July 23, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antejavor antejavor antejavor approved these changes

Assignees

@as51340 as51340

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@as51340 @antejavor