Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest signatures #311

Merged
merged 17 commits into from
Jul 4, 2024
Merged

Add latest signatures #311

merged 17 commits into from
Jul 4, 2024

Conversation

katarinasupe
Copy link
Contributor

@katarinasupe katarinasupe commented Jun 24, 2024

Description

Updated procedures signatures to match the latest Memgraph. Skipped test for procedure signatures. Updated test for constraint to remove reserved keyword text in the latest Memgraph.

Pull request type

Please delete options that are not relevant.

  • Bugfix

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

  • Core feature implementation
  • Tests
  • Code documentation
  • Documentation on gqlalchemy/docs

######################################

Sorry, something went wrong.

@katarinasupe katarinasupe marked this pull request as ready for review June 24, 2024 14:03
@katarinasupe
Copy link
Contributor Author

Added new signatures, but tests kept failing. I spoke shortly with @Josipmrden and the decision is to skip the test for now. This is not as important and it's blocking other features from being merged.

TODO: check fail on constraints test.

@katarinasupe katarinasupe added the status: draft PR is in draft phase label Jun 24, 2024
@katarinasupe
Copy link
Contributor Author

I found the reason why test for constraints was failing - memgraph/memgraph#2136

@katarinasupe katarinasupe added status: ready PR is ready for review and removed status: draft PR is in draft phase labels Jun 24, 2024
@katarinasupe
Copy link
Contributor Author

@antepusic @as51340 @Josipmrden I will just need approval so I can merge after all tests pass

Copy link
Contributor

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antepusic antepusic assigned antepusic and katarinasupe and unassigned antepusic Jun 25, 2024
@antepusic antepusic added this to the v1.6.0 milestone Jun 25, 2024
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

@katarinasupe katarinasupe merged commit 69180c2 into main Jul 4, 2024
5 checks passed
@katarinasupe katarinasupe deleted the add-latest-signatures branch July 4, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants