-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latest signatures #311
Conversation
Added new signatures, but tests kept failing. I spoke shortly with @Josipmrden and the decision is to skip the test for now. This is not as important and it's blocking other features from being merged. TODO: check fail on constraints test. |
I found the reason why test for constraints was failing - memgraph/memgraph#2136 |
@antepusic @as51340 @Josipmrden I will just need approval so I can merge after all tests pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good!
Description
Updated procedures signatures to match the latest Memgraph. Skipped test for procedure signatures. Updated test for constraint to remove reserved keyword text in the latest Memgraph.
Pull request type
Please delete options that are not relevant.
Checklist:
######################################
Reviewer checklist (the reviewer checks this part)
######################################