Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage mode info #309

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Add storage mode info #309

merged 7 commits into from
Jul 10, 2024

Conversation

katarinasupe
Copy link
Contributor

Description

I added getter and setter for storage modes. I also updated the test setup to set storage mode to in-memory transactional by default.

Pull request type

  • Feature

Related issues

Delete section if this PR doesn't resolve any issues.

Closes #239

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation @katarinasupe TODO: generate reference guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

  • Core feature implementation
  • Tests
  • Code documentation
  • Documentation on gqlalchemy/docs

######################################

@katarinasupe katarinasupe added this to the v1.6.0 milestone Jun 24, 2024
@katarinasupe katarinasupe added feature feature type: enhancement New feature or request and removed feature feature labels Jun 24, 2024
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should cover the behavior of this feature when Memgraph is in a state that doesn’t allow changing storage modes (see my comment below)

gqlalchemy/vendors/memgraph.py Show resolved Hide resolved
@antepusic antepusic added the status: change PR reviewed - needs changes label Jun 24, 2024
@antepusic antepusic mentioned this pull request Jun 24, 2024
11 tasks
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katarinasupe katarinasupe requested a review from antepusic July 9, 2024 12:28
@katarinasupe katarinasupe added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Jul 9, 2024
@katarinasupe katarinasupe merged commit 2b8e32a into main Jul 10, 2024
5 checks passed
@katarinasupe katarinasupe deleted the add-storage-info branch July 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready for review type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add STORAGE MODE query to query builder
3 participants