-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage mode info #309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katarinasupe
requested review from
Josipmrden,
as51340 and
antepusic
as code owners
June 24, 2024 11:13
katarinasupe
added
feature
feature
type: enhancement
New feature or request
and removed
feature
feature
labels
Jun 24, 2024
antepusic
suggested changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should cover the behavior of this feature when Memgraph is in a state that doesn’t allow changing storage modes (see my comment below)
antepusic
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
katarinasupe
added
status: ready
PR is ready for review
and removed
status: change
PR reviewed - needs changes
labels
Jul 9, 2024
antepusic
approved these changes
Jul 9, 2024
Josipmrden
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added getter and setter for storage modes. I also updated the test setup to set storage mode to in-memory transactional by default.
Pull request type
Related issues
Delete section if this PR doesn't resolve any issues.
Closes #239
Checklist:
######################################
Reviewer checklist (the reviewer checks this part)
######################################