Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex operator #304

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Add regex operator #304

merged 2 commits into from
Jul 9, 2024

Conversation

imilinovic
Copy link
Contributor

@imilinovic imilinovic commented Feb 18, 2024

Description

Add regex operator (it already exists in Memgraph).

Pull request type

closes #267

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring with functional or API changes
  • Refactoring without functional or API changes
  • Build or packaging related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete section if this PR doesn't resolve any issues.

Closes (link to issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

  • Core feature implementation
  • Tests
  • Code documentation
  • Documentation on gqlalchemy/docs

######################################

@imilinovic imilinovic added feature feature Docs needed Docs needed labels Feb 18, 2024
@imilinovic imilinovic self-assigned this Feb 18, 2024
@katarinasupe katarinasupe added this to the v1.6.0 milestone Jun 5, 2024
@katarinasupe
Copy link
Contributor

katarinasupe commented Jun 24, 2024

@imilinovic We no longer use the develop branch for the release; everything goes directly to the main. Please rebase.
Why there are 96 changes? It's quite hard to review.

FYI, as discussed, this will be included in the next release (July 10th). Work on Memgraph is a priority, so we can move the milestone due date if you can't make it.

@imilinovic imilinovic changed the base branch from develop to main July 1, 2024 06:27
@imilinovic imilinovic marked this pull request as ready for review July 1, 2024 06:29
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a test for this

@katarinasupe
Copy link
Contributor

@antepusic isn't the test added by parametrizing the existing test?

Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katarinasupe You're right, approved

@katarinasupe
Copy link
Contributor

@imilinovic merge the latest main for tests to pass.
Once the tests pass, feel free to squash and merge.

@imilinovic imilinovic merged commit 43c302f into main Jul 9, 2024
5 checks passed
@imilinovic imilinovic deleted the add-regex-operator branch July 9, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs needed Docs needed feature feature
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] Missing Cypher operators
4 participants