Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ViewPropTypes #937

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

xfelipesobral
Copy link

@xfelipesobral xfelipesobral commented Aug 5, 2022

Platforms affected

All

What does this PR do?

ViewPropType is not available in react-native anymore and fix this depreciation changing ViewPropType to PropTypes.object

What testing has been done on this change?

Local testing, to ensure the deprecation warning has been removed.

Tested features checklist

@sturmenta
Copy link

why do you remove so many files?

@sturmenta
Copy link

This repo is definitely abandoned, to solve this problem temporarily you can use a recent fork where only this problem is solved.

following this medium post you can simply do:

yarn remove react-native-snap-carousel
yarn add apurba-bware/react-native-snap-carousel#5a7f809e921262e4e2f646e8cfc4da85f7bd663d

and possibly react-native start --reset-cache

@xfelipesobral
Copy link
Author

why do you remove so many files?

Hello! I removed the examples because it doesn't fit my use case. 😁👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants