feat: produce a hard error for bs.* attributes
#1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchavarri
reviewed
Jan 23, 2024
ppx/ast_attributes.ml
Outdated
| let warn_if_non_namespaced ~loc txt = | ||
| if not (Mel_ast_invariant.is_mel_attribute txt) then | ||
| Mel_ast_invariant.warn ~loc Deprecated_non_namespaced_attribute | ||
| let warn_if_bs_or_non_namespaced ~loc txt = |
There was a problem hiding this comment.
Maybe the function could be renamed to error_if_bs_or_non_namespaced.
ppx/ast_attributes.ml
Outdated
| @@ -130,7 +140,9 @@ let process_attributes_rev attrs : attr_kind * attribute list = | |||
| let process_pexp_fun_attributes_rev attrs = | |||
| List.fold_left | |||
| ~f:(fun (st, acc) ({ attr_name = { txt; _ }; _ } as attr) -> | |||
| match txt with "mel.open" -> (true, acc) | _ -> (st, attr :: acc)) | |||
| match txt with | |||
| | "mel.open" | "bs.open" -> (true, acc) | |||
There was a problem hiding this comment.
What does this attribute do? It's not documented in melange.re.
Also, should warn_if_bs_or_non_namespaced be called in this case too?
There was a problem hiding this comment.
@mel.open extracts an OCaml exn from an external JS data source. Check some old docs here: https://melange.re/melange/Manual.html#__code_bs_open_code_type_safe_external_data_source_handling_since_1_7_0
There was a problem hiding this comment.
anmonteiro
added a commit
that referenced
this pull request
Jan 29, 2024
* feat: produce a hard error for `bs.*` attributes * chore: address code review items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bs.*attributes means that some modules now produce errors at runtime if they have old code -- this is unacceptable.bs.*attribute