Blasting Highlight Event Visual Bug? #8240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pupnewfster
requested changes
Oct 24, 2024
| @@ -385,7 +385,9 @@ public void onBlockHover(RenderHighlightEvent.Block event) { | |||
| Lazy<VertexConsumer> lineConsumer = Lazy.of(() -> renderer.getBuffer(RenderType.lines())); | |||
| for (Entry<BlockPos, BlockState> block : blocks.entrySet()) { | |||
| BlockPos blastingTarget = block.getKey(); | |||
| if (!pos.equals(blastingTarget) && !ClientHooks.onDrawHighlight(levelRenderer, info, rayTraceResult, event.getDeltaTracker(), matrix, renderer)) { | |||
| // simulate ray tracing results for all block positions | |||
| BlockHitResult currResult = new BlockHitResult(rayTraceResult.getLocation(), rayTraceResult.getDirection(), blastingTarget, rayTraceResult.isInside()); | |||
There was a problem hiding this comment.
I believe this can be rayTraceResult.withPosition(blastingTarget). We can also jjust inline it in the call to ClientHooks#onDrawHighlight so that we don't have to construct the new object for if the position is already the blasting target.
There was a problem hiding this comment.
how did you know that helper exists 😮
pupnewfster
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time trying to contribute something to someone else's repo, please be kind.
Problem
I was looking at the
RenderHighlightEventcode for the AoE blasting, and I noticed that you are calling recursiveRenderHighlightEvents for each block affected, so that they may have a chance to cancel themselves.However, when creating those recursive events, you pass the original
rayTraceResultas parameter. I believe this means that instead of simulating one event for each block in the AoE, you actually simulate the origin-block's event many times over.Changes proposed in this pull request:
Create a seperate
BlockHitResultfor eachblastingTargetblockPos. For its parameters, I essentially cloned the originalBlockHitResult, changing only the blockPos. So for example if the original block was 'hit' at the top left, every AoE block is going to simulate a top left hit aswell.