Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite how transporters transfer items along their calculated paths #7748

Draft
wants to merge 4 commits into
base: 1.19.x
Choose a base branch
from
Draft

Rewrite how transporters transfer items along their calculated paths #7748

wants to merge 4 commits into from

Conversation

pupnewfster
Copy link
Member

Changes proposed in this pull request:

Draft PR for now, description will be updated as things are implemented and figured out better, but general idea of this will be to:

  • Adds Game Tests to validate transfer behavior of Logistical Transporters and ensure it remains consistent as things are rewritten
  • Slightly improves memory churn of path caching by making cached paths immutable and using the cached list directly in the destination logic rather than copying it
  • Make item movement along paths happen at a network level instead of having each transporter have to keep track of the stacks that are currently in them and forward them onto the next transporter in the path. This should greatly improve server client networking, as well as hopefully fix some bugs and provide a general improvement to performance by having path invalidation and recalculation happen as needed rather than eagerly.

@pupnewfster pupnewfster mentioned this pull request Apr 7, 2023
Open
@pupnewfster pupnewfster mentioned this pull request Feb 29, 2024
Closed
pupnewfster added a commit that referenced this pull request Apr 13, 2024
@pupnewfster
Restructure our GameTests:
b792593 
- Added the tests for transporters from (#7748)
- Reduced the number of game test sourcesets to one, and allow it to access all the other mekanism modules
- Make use of Neo's Game Test Framework as it is nicer to work with and will eventually allow us to validate the tests via GHA
- Moved the run configs to using their own run folders
pupnewfster added a commit that referenced this pull request Apr 15, 2024
@pupnewfster
Short circuit a little logic to avoid looking up the side multiple ti…
89e70aa 
…mes for transporters, mostly bringing parity up to (#7748) except for the network wide changes
@Gamercave
Copy link

has this been merged into a specific 1.19.2 download we are currently facing a consistent crash issue on a server and I am hoping their may be a version where this is a quick solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.19 efficiency enhancement Mekanism
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pupnewfster @Gamercave