Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the proximity precision option #351

Merged
merged 3 commits into from May 8, 2024

Conversation

KatsukiFujimoto
Copy link
Contributor

Pull Request

Related issue

N/A

What does this PR do?

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@brunoocasali brunoocasali requested a review from ellnix May 7, 2024 17:42
@brunoocasali
Copy link
Member

Can you rebase your code now?!

@KatsukiFujimoto
Copy link
Contributor Author

Thank you for fixing the issue.
I rebased this branch.

Copy link
Collaborator

@ellnix ellnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @KatsukiFujimoto 👍

@ellnix
Copy link
Collaborator

ellnix commented May 8, 2024

bors merge

@meili-bors meili-bors bot merged commit b7b1aaf into meilisearch:main May 8, 2024
10 checks passed
meili-bors bot added a commit that referenced this pull request May 10, 2024
357: Update version for the next release (v0.13.0) r=brunoocasali a=ellnix

We should ship the fix to #352 ASAP, and also add support for #351, I believe that would mean a minor version in semver.

Co-authored-by: ellnix <[email protected]>
@ellnix ellnix added the enhancement New feature or request label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants