Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try ValueKind::U64 also when convet the json to Value #394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

try ValueKind::U64 also when convet the json to Value #394

wants to merge 1 commit into from

Conversation

deftsp
Copy link

@deftsp deftsp commented Nov 28, 2022

No description provided.

matthiasbeyer
matthiasbeyer approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@matthiasbeyer
Copy link
Collaborator

That error is unrelated. Please rebase once #395 is merged.

@matthiasbeyer
Copy link
Collaborator

Hi, do you care to rebase this?

@polarathene polarathene mentioned this pull request Oct 9, 2023
Open
@matthiasbeyer matthiasbeyer added the hacktoberfest-accepted Accepted PR for hacktoberfest label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted PR for hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deftsp @matthiasbeyer