Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced broken link in Get Started button. #142

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from
Open

Replaced broken link in Get Started button. #142

wants to merge 3 commits into from

Conversation

lucastuozzo
Copy link

No description provided.

ThaNarie
ThaNarie approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@ThaNarie ThaNarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff makes it impossible to see what's actually changed, so I trust you :D

ThijsTyZ
ThijsTyZ requested changes Jun 19, 2020
View reviewed changes
Copy link

@ThijsTyZ ThijsTyZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there so many changes? It looks like you changed more than just the start button

@ThaNarie
Copy link
Member

The indenting changed

@lucastuozzo
Copy link
Author

The only change I did was the link on my second commit. On my first commit, it's all indentantion changes. My link fix was not saved.

@ThijsTyZ
Copy link

Can you revert the indenting? Since that is not related to this issue and makes it impossible to review

@lucastuozzo
Copy link
Author

I undid the indenting.

ThaNarie
ThaNarie requested changes Jun 19, 2020
View reviewed changes
Copy link
Member

@ThaNarie ThaNarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait with the merge, just remembered the source of this site is somewhere else. You changed the build output :)

Let me find it for you :)

@lucastuozzo
Copy link
Author

My bad. I did not know which one was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThaNarie ThaNarie ThaNarie requested changes

@ThijsTyZ ThijsTyZ ThijsTyZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucastuozzo @ThaNarie @ThijsTyZ