Fix an issue in Quality where the initial button press does not work on a touch device #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…device (tested with chromebook in touch mode), due to the fact that the mouseenter event gets triggered when you click the button, causing both mouseevent and click event to trigger right after each other, making the click cancel out the touchenter event. It fixes it by keeping track of when the last displayType (hide / show) happened, and rejecting it when the time between the last one and the current one is less than 16 milliseconds ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with: chromebook in touch mode,
The problem:
Due to the fact that the mouseenter event gets triggered when you click the button,
causing both mouseevent and click event to trigger right after each other,
making the click cancel out the touchenter event.
This pull request fixes the issue by keeping track of when the last call to hideSelector or showSelector happened,
and rejecting it when the time between the last one and the current one is less than 16 milliseconds ago.