add display-mode: picture-in-picture example and fix sizing issue #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdavidmills
requested review from
pepelsbey
and removed request for
a team
|
@pepelsbey, would you mind giving this little demo tweak a review? |
pepelsbey
approved these changes
Mar 11, 2024
Co-authored-by: Vadim Makeev <[email protected]>
|
@pepelsbey thanks! Are you able to merge it? I don't have permission to do so in this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome 123 adds support for the
@mediadisplay-modepicture-in-picturevalue. This PR adds CSS to our document picture-in-picture example that combinesdisplay-mode: picture-in-picturewithprefers-color-schemeto provide a light and dark color scheme just for the picture-in picture window.