Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use SVG for conditional reqs diagrams #33607

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented May 14, 2024

Description

This PR converts existing .png to use SVG format. The mermaid source are being added to shared assets in parallel.

Motivation

Reducing binary assets, maintenance of diagrams by adding source files.

How to review this PR

For convenience, it may be best to compare the preview URL generated here with the live page at https://developer.mozilla.org/en-US/docs/Web/HTTP/Conditional_requests#use_cases

Related issues and pull requests

@bsmth bsmth added the reduce binary assets Efforts to remove or convert binary assets label May 14, 2024
@bsmth bsmth requested a review from a team as a code owner May 14, 2024 13:33
@bsmth bsmth requested review from teoli2003 and removed request for a team May 14, 2024 13:33
@github-actions github-actions bot added Content:HTTP HTTP docs size/xl >1000 LoC changed labels May 14, 2024
Copy link
Contributor

github-actions bot commented May 14, 2024

Preview URLs

(comment last updated: 2024-05-14 13:35:15)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs reduce binary assets Efforts to remove or convert binary assets size/xl >1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant