Fix detection of previous PR annotation comments #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkdownFormatterFactory uses System.lineSeparator() as the end-of-line character for annotation comments. GraphqlGithubClient.postSummaryComment(), however, uses hardcoded \r\n as end-of-line character, so it isn't able to match legitimate comments if SonarQube is not running on Windows. This change updates GraphqlGithubClient to also use system end-of-line char.
GreyTeardrop
force-pushed
the
fix-comment-minimizing
branch
from
b9642e0
to
c7f801f
Compare
|
Thank you @GreyTeardrop , @mc1arke is it possible to merge this one soon please? it's very annoying to have spam of comments on PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems like the #884 change has affected minimization of comments for SonarQube instances that run on Linux or macOS.
The root cause is that
MarkdownFormatterFactoryusesSystem.lineSeparator()as the end-of-line character for annotation comments.GraphqlGithubClient.postSummaryComment(), however, uses hardcoded\r\nas end-of-line character, so it isn't able to match legitimate comments if SonarQube is not running on Windows.This change updates
GraphqlGithubClientto also use system end-of-line char.(It also moves
String.formatcall out of the comment iteration logic to avoid making multiple identical calls).