-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
point-text option in -style to provide text tag symbol as point #303
Open
cedricsam
wants to merge
574
commits into
mbloch:master
Choose a base branch
from
cedricsam:symbol-text
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricsam
force-pushed
the
symbol-text
branch
from
February 6, 2019 18:43
0ad4da1
to
4ad83b0
Compare
Hi @mbloch, this is now quite old, but I was wondering if it was in line with what you had in mind for mapshaper and SVG output? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is old code from January. I'm not sure if I should just start over with the latest commits, or we can just attempt to merge. At least, we can discuss that.
The goal is to provide a way in SVG output to specify a
<text>
tag to output in place of a circle or rect, as the point's element on the map. That's for use cases where we have glyphs in a custom font, say airport or seaport symbols, that we want to render as text. Not sure if there are other ways to render on the map...