Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support embedding video #117

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dHannasch
Copy link

This includes video support by default, with a demonstration page modeled on the image demonstration page. Interested?

Adding video support turned out to be a little fiddly due to interactions with the other plugins, so I thought it might be worth including doing it the "right" way directly in the starter.

I'm not sure how best to handle duplicating plugins between the gatsby-transformer-remark entry and gatsbyRemarkPlugins. gatsbyjs/gatsby#15486 is theoretically resolved, but appears to not always be resolved for everyone (gatsbyjs/gatsby#15486 (comment)). We could probably remove the duplication (including both gatsby-remark-images and gatsby-remark-embed-video) but it might be worth keeping a few more months so that someone trying to use the starter doesn't get blindsided by an unforeseen leftover of gatsbyjs/gatsby#15486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant