service: add libnotify service

[FFY00]

Signed-off-by: Filipe Laíns [email protected]

[maximbaz]

I think we should include this in the existing service, not make a duplicate one... Because you don't want users to accidentally run both services at the same time (nothing bad will happen, but still).

How about we add EnvironmentFile=/path/to/some/file and then allow users to customize extra args to the binary?

[FFY00]

Yes, that makes sense.

[FFY00]

What do you think of this approach? Use @ to allow users to pass arguments to the service.

[maximbaz]

It feels a bit hacky and wouldn't allow to pass two arguments (imagine someone needs to pass -u2f-authpending-path "/new/path/to/pam-u2f-authpending")...

I'm grepping svn-community now, I can see for example sway is doing EnvironmentFile=-%h/.config/sway/env, shall we just do the same?

EnvironmentFile=-%h/.config/yubikey-touch-detector/service.conf

And actually, we can make the binary itself respect these environment variables, not to pass them via CLI arguments. In other words, we will not define ARGS in service.conf, but we will define YUBIKEY_TOUCH_DETECTOR_LIBNOTIFY=true and YUBIKEY_TOUCH_DETECTOR_U2F_AUTHPENDING_PATH="/new/path/to/pam-u2f-authpending".

What do you think, is this going to be cleaner? If you agree, wanna implement this or should I take over? :)

[FFY00]

It feels a bit hacky and wouldn't allow to pass two arguments (imagine someone needs to pass -u2f-authpending-path "/new/path/to/pam-u2f-authpending")...

You could actually pass several arguments:

yubikey-touch-detector@'--libnotify -u2f-authpending-path /new/path/to/pam-u2f-authpending'.service

But you are correct, it is a bit hacky. I will try to push a patch with the changes you requested.

[maximbaz]

a friendly ping @FFY00, still interested in finishing this or should I take over? :)

[FFY00]

I am interested but I have other stuff to do, you can take over 😁.

[maximbaz]

Implemented in 54f876a, gonna release 1.4.0 now, let me know if you spot anything wrong with it 👍