Pull version from single SoT (main.go)

[mmonaco]

This might be helpful, no worries otherwise :)

This could go the other way around too, stamping it in with -ldflags='-X appVersion=$(VERSION)'

[maximbaz]

Thanks! I think I most often saw others use the alternative -ldflags way, let's do it that way!

[mmonaco]

Thanks! I think I most often saw others use the alternative -ldflags way, let's do it that way!

Sure, will do.

The difference is whether you only want a version to come from the build system so that you'd get something like:

$ go run main.go --version
YubiKey touch detector version: <UNDEFINED>

[maximbaz]

Hmmm very good point, sorry allow me to change my mind, let's go with your current version 😅

[maximbaz]

Would there be any downsides with the simpler sed command like the one I pushed?

[mmonaco]

Would there be any downsides with the simpler sed command like the one I pushed?

Not really. The main difference is that I was trying to be flexible with

const appVersion =

vs

const (
  appVersion = ...
)

[maximbaz]

OK I'll be mindful about it, thanks!

[mmonaco]

OOC, unrelated, why do you vendor the deps like this? I think this is meant for checking in the deps. If you're going to .gitignore the vendor dir, why not let the default go pkg cache be used?

[maximbaz]

I add a tarball with vendored dependencies to the release only because some distros build (or prefer to build) offline, which is a problem if they need to allow internet to run go get.

I haven't been using Makefile for local development for a while, I suppose it's not correct that my local target depends on vendor, it shouldn't. Was this the part that made you ask about it?

[mmonaco]

Ah, that make sense! Yeah I saw it show up when I did make run.

I guess you could have:

.PHONY: run
run: build
        ./$(BIN)

and drop local altogether

[maximbaz]

Agree, just pushed 👍