-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gpgme for gpg detector, misc style fixes #51
Conversation
the hmac watcher could be migrated to use ykpers, but i don't have a setup to test for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It's a very interesting idea to use gpgme, it certainly makes it somewhat less hacky 😁
I only have a single comment, a proposal to fix the app occasionally hang.
Admittedly I don't use it myself either, but I believe it's as easy to set it up as to follow this: $ ykman config usb -e OTP # enable OTP if you have it disabled
$ ykman otp chalresp --touch --generate 2 # generate a new random key in slot 2
$ ykman otp calculate 2 # when asked, give it any value (e.g. 00), then this will require touch Interestingly, the current code does not detect the need to touch yubikey (for me). I don't know if it regressed (nobody opened an issue!), a quirk of my personal computer, or an issue in the setup above. But if you want to try it out, give it a go 😁 |
use gpgme for gpg detector move ssh socket to ~ suffix
revised with the suggestions. |
|
FYI I doubled the timings, because I experienced sporadic false positives when executing We might have to increase them even more, if people report that on their computers they still get false positives... I also cut 1.11.0 release, so you can just take the latest tag for packaging 😉 |
use gpgme for gpg detector
move ssh socket to ~ suffix