Use native D-Bus and libnotify implementation #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! I'll try to get this tested and merged in the following days! |
|
Was about to open a bug report for this. Thanks for contributing a fix already! 🎉 😃 👍 |
maximbaz
reviewed
Sep 9, 2021
This change makes the libnotify-compatible notifications more resilient by switching to a different library that uses a native implementation of the D-Bus protocol. The prior implementation of the notifications code reserved a single notification identifier when the program started; however, some notification daemons (like mate-notification-daemon) automatically terminate after some period of notification inactivity. They are reactivated by writing new notifications via D-Bus. In this case, the generated ID would no longer make sense to the newly activated process, and show the notification would fail. With the help of the new library, this change keeps track of the notification ID and only reserves it while the notification is actually being shown.
|
Many thanks 😉 |
|
@maximbaz Please tag a new release including this MR. 👍 |
|
Done, enjoy 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the libnotify-compatible notifications more resilient by switching to a different library that uses a native implementation of the D-Bus protocol.
The prior implementation of the notifications code reserved a single notification identifier when the program started; however, some notification daemons (like mate-notification-daemon) automatically terminate after some period of notification inactivity. They are reactivated by writing new notifications via D-Bus. In this case, the generated ID would no longer make sense to the newly activated process, and show the notification would fail.
With the help of the new library, this change keeps track of the notification ID and only reserves it while the notification is actually being shown.