explicitly abort heartbeat task

maxcountryman · Nov 13, 2024 · 4c2bec5 · 4c2bec5
1 parent ff1ff33
commit 4c2bec5
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/worker.rs b/src/worker.rs
@@ -778,14 +778,10 @@ impl<T: Task + Sync> Worker<T> {
                 let retry_policy = &in_progress_task.retry_policy;
                 self.handle_task_timeout(&mut tx, &in_progress_task, retry_policy, timeout).await?;
             }
-
-            // Select the heartbeat task so that it'll be cancelled after execution or timeout.
-            _ = heartbeat_task => {
-                tracing::error!("Heartbeat task failed unexpectedly (this is a critical error!)");
-            }
-
         }
 
+        heartbeat_task.abort();
+
         tx.commit().await?;
 
         Ok(Some(task_id))