handle Membership #527
Merged
handle Membership #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
reviewed
Aug 8, 2024
tulir
reviewed
Aug 8, 2024
maltee1
force-pushed
the
handle_matrix_membership
branch
from
7908fbd
to
0f3afe0
Compare
tulir
reviewed
Aug 9, 2024
tulir
reviewed
Aug 9, 2024
pkg/signalid/ids.go
Outdated
Comment on lines
42
to
57
| func ParseUserLoginID(userLoginID networkid.UserLoginID) (uuid.UUID, error) { | ||
| userID, err := ParseUserLoginID(userLoginID) | ||
| if err != nil { | ||
| return uuid.Nil, err | ||
| } | ||
| return userID, nil | ||
| } | ||
|
|
||
| func ParseUserIDAsServiceID(userID networkid.UserID) (libsignalgo.ServiceID, error) { | ||
| return libsignalgo.ServiceIDFromString(string(userID)) | ||
| } | ||
|
|
||
| func ParseUserLoginIDAsServiceID(userLoginID networkid.UserLoginID) (libsignalgo.ServiceID, error) { | ||
| return libsignalgo.ServiceIDFromString(string(userLoginID)) | ||
| } | ||
|
|
There was a problem hiding this comment.
I think your force push reverted these fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrix -> signal membership. Missing are knocks and joins, as they need access to groupmasterkeys through invite links, which is a little more complicated. Those will follow later.