add relay mode #392
Merged
add relay mode #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltee1
force-pushed
the
relay_mode
branch
4 times, most recently
from
3b7bfde
to
6d3dc02
Compare
|
I would request a review at this point. One major problem is that the bridge doesn't seem to support outgoing captions yet (although the code looks like it does). That means that Images are sent without "MatrixUser sent an Image" etc. and thus cannot be assigned to a user. I sent an image with a caption from Telegram via double-puppeting from Telegram, so the format should be correct. I currently don't know how to fix that but I will file a bug. Text messages and emotes work fine. |
tulir
approved these changes
Dec 26, 2023
tulir
reviewed
Dec 26, 2023
Co-authored-by: Tulir Asokan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I currently don't have time for thorough testing & cleanup, but I have been able to relay a message to Signal.
Please give this a whirl if you have time. I will otherwise do thorough testing and cleanup at some later point.