Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first version of libdirsearch #960

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

InsaneMiner
Copy link

@InsaneMiner InsaneMiner commented Sep 8, 2021

Description

What will it do?
This is the first version of the libdirsearch. This allows you to use dirsearch as a lib. This is the first version so i have not made it perfect. If anyone has ideas what i should add then please make a new issue.
If this PR will fix an issue, please address it:
Fix #{issue}

Requirements

  • Add your name to CONTRIBUTERS.md
  • If this is a new feature, then please add some additional information about it to CHANGELOG.md

@shelld3v
Copy link
Collaborator

shelld3v commented Sep 8, 2021

@InsaneMiner How this will be used as a lib? What is the syntax?

@InsaneMiner
Copy link
Author

InsaneMiner commented Sep 8, 2021

@shelld3v shelld3v added the not ready Pull request can't be merged or issue can't be worked on yet label Sep 8, 2021
@maurosoria
Copy link
Owner

@InsaneMiner
Copy link
Author

self.report_manager.update_report(self.report)
exit(0)


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too many new lines here, please follow pep8 rules: https://www.python.org/dev/peps/pep-0008/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, what is the difference between Controller and LibController?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, what is the difference between Controller and LibController?

I think so, i can't remember


dirsearch.run(args)

print(dfh.dirs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All files should be ended with a new line

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I would like to rename the folder to examples, as in the future there will be more examples

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I would like to rename the folder to examples, as in the future there will be more examples

ok

@shelld3v
Copy link
Collaborator

Hi, can we move stuff inside libdirsearch.py to dirsearch.py? In case __name__ == "__main__", we call the Program class (for console usage); otherwise, use it as a lib

@shelld3v
Copy link
Collaborator

More about your PR's linting issues can be found here: https://github.com/maurosoria/dirsearch/pull/960/checks?check_run_id=3727897089

@InsaneMiner
Copy link
Author

Hi, can we move stuff inside libdirsearch.py to dirsearch.py? In case __name__ == "__main__", we call the Program class (for console usage); otherwise, use it as a lib

yeah

@shelld3v shelld3v marked this pull request as draft July 1, 2022 04:20
@shelld3v shelld3v removed the not ready Pull request can't be merged or issue can't be worked on yet label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants