Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only parse files that end with ".strm" extension #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only parse files that end with ".strm" extension #154

wants to merge 1 commit into from

Conversation

felixangell
Copy link

No description provided.

@felixangell felixangell changed the title Only parse arguments that end with ".strm" extension Only parse files that end with ".strm" extension Nov 21, 2016
@matz
Copy link
Owner

matz commented Nov 22, 2016

Could you tell me your intention? Many programming languages (including Ruby, Python, and others) do not care about file name extensions. They are only convention.

@felixangell
Copy link
Author

felixangell commented Nov 22, 2016

I figured it adds a level of consistency and makes parsing flags in the long run simpler. It also gives some nice feedback to the user rather than just hanging and waiting for input.

@felixangell
Copy link
Author

felixangell commented Nov 22, 2016

To add to that, enforcing restrictions in some cases is better in the long term. Consider: ".h" vs ".hpp" in C++, which causes things like, for instance, the GH syntax highlighter having to disambiguate the two as C or C++ by doing weird parses over the code or looking for certain symbols. People don't always follow conventions :-)

There's also: cpp, cc, C, cxx, c++ and hh H, hxx, hpp, h++, etc. Good to be consistent to avoid that.

@mattn
Copy link
Contributor

mattn commented Nov 24, 2016

I can not find a value for add this. :-(
And I don't understand why you skip files which don't have .strm extension.

@felixangell
Copy link
Author

Haha, that's fine. Not many languages do this, the only language that comes to mind is the Go programming language.

@mattn
Copy link
Contributor

mattn commented Nov 24, 2016

I can understand if the arguments is pointed to the directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants