Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to play sound when muted or unmuted (disabled by default) #14

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nicooprat
Copy link

Thanks for this plugin!

This PR adds sounds from https://rcptones.com/dev_tones/ (check beep_short_on and beep_short_off) when muted or unmuted.

It's disabled by default, I added a very simple option page to turn it on.

Tested on latest Chrome & Firefox. To test it as a temporary plugin in Firefox, this should be added in the manifest:

"applications": {
  "gecko": {
    "id": "YOUR_EMAIL_ADDRESS",
    "strict_min_version": "53.0"
  }
}

What do you think?

@nicooprat
Copy link
Author

@mattsimonis Hi, did you have any chance to have a look at this PR? I'm using it as is for a few month now and didn't find any bug. I just merged your latest changes about the new Google Meet UI too.

Thanks!

@magnetikonline
Copy link

This looks great @nicooprat. What do you think @mattsimonis? Seems like a really nice addition to your very handy plugin. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants