Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new Map() always returning Map<unknown, unknown> #207

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Fix new Map() always returning Map<unknown, unknown> #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bac029e
Add (failing) test for `new Map()` being passed as a literal to somew…
amitdahan Sep 1, 2024
2235d51
Fix it
amitdahan Sep 1, 2024
81c89e5
Ensure parameter-ful ctor keeps working
amitdahan Sep 1, 2024
cc20e81
add another test
amitdahan Sep 1, 2024
922f8a8
Add a test for passing `new Map()` to a function that expects some ge…
amitdahan Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/entrypoints/map-constructor.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
interface MapConstructor {
new (): Map<unknown, unknown>;
new <K = unknown, V = unknown>(): Map<K, V>;
}
26 changes: 26 additions & 0 deletions src/tests/map-constructor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,29 @@ doNotExecute(() => {

type testClear = [Expect<Equal<typeof cleared, void>>];
});

doNotExecute(() => {
const map = new Map() satisfies Map<string, boolean>;
type test = [Expect<Equal<typeof map, Map<string, boolean>>>];
});

doNotExecute(() => {
amitdahan marked this conversation as resolved.
Show resolved Hide resolved
const map: Map<string, boolean> = new Map();
type test = [Expect<Equal<typeof map, Map<string, boolean>>>];
});

doNotExecute(() => {
function expectsBooleanMap(map: Map<string, boolean>) {
return map;
}
const map = expectsBooleanMap(new Map());
type test = [Expect<Equal<typeof map, Map<string, boolean>>>];
});

doNotExecute(() => {
const map = new Map([
["foo", 1],
["bar", 2],
]);
type test = [Expect<Equal<typeof map, Map<string, number>>>];
});