Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement the suggestion in #142
It declares the fill method on a readonly array as never (because fill mutates the original array)
It could be improved by removing the method completely from the interface so if someone has any advice on how to do that let me know
It also changes the fill method on the normal array by typing it based on the type of the value provided
Before:
After:
This takes into consideration the rest of the arguments of the fill function such that:
You can see an example of this in the tests
Note
This type only works if there is a newly created array, it doesn't retype the original array itself
I'm also open to any help or suggestions for this