Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs CI and fix some bugs in it #90

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 14, 2023

This copies all the setup from Matplotlib so we get doc builds from Circle CI with posted build artifacts, errors, warnings, etc., on PRs.

This is based on #88.

@QuLogic
Copy link
Member Author

QuLogic commented Apr 14, 2023

Hmm, bit confused why installing extras with .[tests] doesn't work here, but does locally. pip is the latest version here AFAICT.

@ksunden
Copy link
Member

ksunden commented Apr 14, 2023

the call has --no-deps for some reason, which is why the [tests] deps are not installed

@QuLogic
Copy link
Member Author

QuLogic commented Apr 14, 2023

the call has --no-deps for some reason, which is why the [tests] deps are not installed

Ah, good catch; I saw that a few times but it didn't register for some reason.

@QuLogic QuLogic marked this pull request as ready for review April 26, 2023 07:15
@ksunden ksunden merged commit 98a09db into matplotlib:main Sep 18, 2023
7 checks passed
@QuLogic QuLogic deleted the fix-docs branch September 18, 2023 21:10
@QuLogic
Copy link
Member Author

QuLogic commented Sep 18, 2023

Oh, this seems to have failed because cycler doesn't have an O variable in the Makefile, only SPHINXOPTS. I'll open a followup now we have the CI working here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants