Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds code to update idvisitor if changed in visits_log table, #DEV-18502 #22890

Draft
wants to merge 1 commit into
base: 5.x-dev
Choose a base branch
from

Conversation

AltamashShaikh
Copy link
Contributor

@AltamashShaikh AltamashShaikh commented Dec 20, 2024

Description:

Adds code to update idvisitor if changed in visits_log table
Fixes: #DEV-18502, #22857

Review

@AltamashShaikh
Copy link
Contributor Author

@matomo-org/core-reviewers Can you guys check if this PR will solve the issue ?

I tested with this scenario

  1. I have a goal which converts when URL contains the word goal1, Request URL: http://localhost.demo.com/test.html?utm_campaign=testChangeIdVisitor1&goal1=&beauthera=&gclid=testChangeID3
  2. Saw the visitorID in log_visit, log_conversion and log_adclickID table
  3. Gave consent _paq.push(['setConsentGiven']);
  4. Reloaded the page and verified the idvisitor in all the 3 tables and it appears to be updated now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant