Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate formFactors client hints for device detecion #22549

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 3, 2024

Description:

Chrome meanwhile supports the additional client hint "formFactors". With matomo-org/device-detector#7807 this will be supported by device detector.

This PR will enable the support within Matomo JavaScript Tracking.

It will help to better identify the device type.

Requires a new version of PHP Tracker to be released and updated before merging.
Therefor depends on matomo-org/matomo-php-tracker#136

For testing the javascript tracker changes: Chrome already supports the formFactors. So using a normal tracking should then include this in the uadata parameter in tracking requests.

Review

Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Sep 18, 2024
@sgiehl sgiehl force-pushed the formfactors branch 4 times, most recently from e897634 to 0088d21 Compare October 8, 2024 13:50
@sgiehl sgiehl removed the Stale The label used by the Close Stale Issues action label Oct 8, 2024
@sgiehl sgiehl added this to the 5.2.0 milestone Oct 8, 2024
@sgiehl sgiehl marked this pull request as ready for review October 8, 2024 16:37
@sgiehl sgiehl added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Data Integrity & Accuracy labels Oct 9, 2024
@sgiehl sgiehl requested a review from a team October 9, 2024 08:39
@sgiehl sgiehl added the Needs Review PRs that need a code review label Oct 9, 2024
@sgiehl sgiehl merged commit 8ee37b8 into 5.x-dev Oct 14, 2024
23 of 25 checks passed
@sgiehl sgiehl deleted the formfactors branch October 14, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Data Integrity & Accuracy Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants