small a11y fixes

[luce-carevic]

Description:

1. There are many decorative icons in Matomo that are not hidden to assistive technologies.

Adding aria-hidden="true" on the tag will hide them.

2. There are many tabindex with value different than 0 or -1.

You should not rely on value superior to 1 because the risk is high to mess with the keyboard navigation.

cf. https://www.tpgi.com/using-the-tabindex-attribute/

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[sgiehl]

Hi @luce-carevic,
Thanks for providing this PR. In order to make a review and check if all tests would still pass the vue files would need to be build.
If you have installed Matomo locally in developer mode you can achieve that by running ./console vue:build

[github-actions]

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

[sgiehl]

@luce-carevic Thanks for providing this PR. The changes around aria-hidden="true" should all be fine. But removing the tabindex in all that places might actually make the tab navigation even worse.
I guess the current order of tabindex isn't very good and there is space for improvements, but not sure if simply removing them is the best choice.
Also the vue files would need to be built. For that you need to run a ./console vue:build and commit the compiled files.

[github-actions]

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

[luce-carevic]

The tabindex are not useful here. The tab order will follow the order in the DOM.

I don't know how to do what you asked. Maybe I should make an issue instead of a PR?

[github-actions]

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

[github-actions]

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers