Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Curl Connection remaining open #133

Merged
merged 6 commits into from
May 21, 2024
Merged

Fix: Curl Connection remaining open #133

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dee06f5
add curl_close and fix undefined variable
May 1, 2024
46205f2
change position of the curl_close
May 2, 2024
3bb0c51
Merge branch 'refs/heads/master' into 128-curl-close
May 10, 2024
6200828
128 - wrap by try-finally block
May 10, 2024
4cbcaf9
Merge branch 'refs/heads/master' into 128-curl-close
May 21, 2024
96d0772
128 - update changelog.md
May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion MatomoTracker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1949,17 +1949,19 @@ protected function sendRequest($url, $method = 'GET', $data = null, $force = fal
}
}

$content = '';

if (function_exists('curl_init') && function_exists('curl_exec')) {
$options = $this->prepareCurlOptions($url, $method, $data, $forcePostUrlEncoded);

$ch = curl_init();
curl_setopt_array($ch, $options);
ob_start();
$response = @curl_exec($ch);
curl_close($ch);
sgiehl marked this conversation as resolved.
Show resolved Hide resolved
ob_end_clean();

$header = '';
$content = '';

if ($response === false) {
$curlError = curl_error($ch);
Expand Down