Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: priority experiments #592

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mathuo
Copy link
Owner

@mathuo mathuo commented Apr 29, 2024

No description provided.

Copy link

codesandbox-ci bot commented Apr 29, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 672da85:

Sandbox Source
customheader-dockview Configuration
dockview-app Configuration
editor-gridview Configuration
events-dockview Configuration
externaldnd-dockview Configuration
fullwidthtab-dockview Configuration
iframe-dockview Configuration
keyboard-dockview Configuration
lockedgroup-dockview Configuration
nativeapp-dockview Configuration
nested-dockview Configuration
rendering-dockview Configuration

@mathuo mathuo force-pushed the 590-add-support-for-priorization-or-calculation-via-a-hook-when-distributing-available-space-in-dockview branch from ef14540 to 58aba53 Compare April 30, 2024 19:27
@qcz
Copy link
Contributor

qcz commented May 1, 2024

@mathuo Thanks for this experiment! It looks very promising, especially preferredSize. However panels rarely have square shaped content: the preferred width most of the time it does not equal with the preferred height.

Some examples:

  • List panel designed for displaying as a narrow vertical bar by default. It has a preferred width of 420px, but no preferred height if I put it above/below a panel (especially not the 420px specified for width).
  • Search box panel: it has a text field for searching. It has a preferred height of 120px and a preferred width of 450px.

@mathuo mathuo force-pushed the 590-add-support-for-priorization-or-calculation-via-a-hook-when-distributing-available-space-in-dockview branch from f2fd7dc to 672da85 Compare May 1, 2024 19:19
@husayt
Copy link

husayt commented May 8, 2024

This is really important to address, while min/max are a good start, day to day using the dockview it is important to be able to set flexible sizes to each panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants