Span<T> & Memory<T> on Fourier #880
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pain points: The CommonParallel.For and Storage APIs are not Span compatible, hence the fallback to Memory and .ToArray(). Hopefully someone more familiar with Math.Net can weigh in here with possible solutions. |
|
Thank you! I really would like to move forward in this direction, and also have some thoughts already. I'll try to get back to you as soon as time permits! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example how an updated API might look (and naive fixing of unit tests).
Whilst doing this, I saw many opportunities for reducing memory allocations so this would probably be the subject of a 2nd pass through this.