Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pressing 'Close' on persistent tabs not working. #790

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HalfVoxel
Copy link
Contributor

@HalfVoxel HalfVoxel commented Apr 23, 2022

Description

Previously, right clicking on a persistent tab and pressing the Close option would just close the app, but not remove the tab. Clicking Close again on a persistent tab which only had a placeholder would do nothing.

This PR fixes this so that it is possible to close persistent tabs.

Checklist:

  • I used indents of four spaces in code and two spaces in documentation
  • I have performed a self-review of my own code, it does not generate any errors
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation or will submit them later
  • I have recompiled gschgema (if there were any changes)
  • Changes to the SASS were done to the variables only or following the proper way

@jntesteves
Copy link
Contributor

If the tab is pinned, the user still needs a way to close the app with the mouse without removing persistence. That's what the Close option does, you can't just remove it without providing a replacement somewhere else, the user needs the option. The Unpin option is there if the user wants to remove that, too.

@PapyElGringo
Copy link
Collaborator

I do agree with @jntesteves here too

@HalfVoxel
Copy link
Contributor Author

That's fair. I agree with that point too.
But I still think that if should close the tab if the tile is just a placeholder. Otherwise to close a pinned tab you first have to unpin it and then click close. Right now the close button on such tabs just silently does nothing. Do you agree?

@PapyElGringo
Copy link
Collaborator

I agree that the useless close button on a placeholder is an issue. We could make it Unpin the placeholder and close it or replace it by Open application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants