feat(field): make required asterisk optional #5616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npeters-dev
force-pushed
the
text-field-optional-asterisk
branch
from
4952f9d
to
be5bb43
Compare
asyncLiz
requested changes
May 16, 2024
Not at all. I added the property to the select component, too. |
asyncLiz
changed the title
asyncLiz
changed the title
copybara-service bot
pushed a commit
that referenced
this pull request
May 23, 2024
PiperOrigin-RevId: 636585863
|
I think more commits got pushed to the PR before copybara finished the import, so it didn't merge propertly. Sorry about that! This got added in c5e87b2 though, so we can close the PR now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5256
Makes the required asterisks optional on text fields by adding an
no-asteriskprop.