Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(TextField): support nullable numeric types #2294

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

capdiem
Copy link
Contributor

@capdiem capdiem commented Dec 23, 2024

No description provided.

@capdiem capdiem requested a review from Copilot December 23, 2024 08:24

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Masa.Blazor/Components/TextField/MTextField.razor.cs:589

  • Ensure that the behavior introduced by the IsNullable method is covered by tests, including both nullable and non-nullable numeric types.
private static bool IsNullable<T>()
@capdiem capdiem requested a review from Copilot December 23, 2024 08:34

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@Qinyouzeng Qinyouzeng merged commit 259f741 into main Dec 23, 2024
1 check passed
@Qinyouzeng Qinyouzeng deleted the bugfix/textfield-number-with-nullable-value branch December 23, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants