fix(Sortable): re-sort by Order through js-interop when items changed
#2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Masa.Blazor/Components/Sortable/MSortableProvider.cs:38
- Using a constant index '1' in the AddContent method will cause all items to be rendered at the same index. This should be replaced with an incremented variable to ensure each item is rendered at a unique index.
sb.AddContent(1, ItemContent?.Invoke(context));
capdiem
commented
Dec 23, 2024
| foreach (var item in Items) | ||
| { | ||
| Dictionary<string, object?> attrs = new() | ||
| { | ||
| { "data-id", ItemKey(item) } | ||
| }; | ||
| var context = new SortableItemContext<TItem>(item, attrs); | ||
| sb.AddContent(i++, ItemContent?.Invoke(context)); | ||
| sb.AddContent(1, ItemContent?.Invoke(context)); |
There was a problem hiding this comment.
It seems that the sequence in the for loop doesn't need to be incremented, as I checked the compiled source code of @foreach in Razor.
Qinyouzeng
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the items change, they should not be rendered in the order of the items. Now, after the items are updated, the UI order should be updated through js-interop based on the
Ordervalue during the next rendering.