🐛 fix(Icon): should not enable transition mode by default (#2029)

masastack · Jul 10, 2024 · 903b5aa · 903b5aa
1 parent 042d1cd
commit 903b5aa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/Masa.Blazor/Components/Icon/MIcon.razor.cs b/src/Masa.Blazor/Components/Icon/MIcon.razor.cs
@@ -114,7 +114,7 @@ public bool IsDark
 
         private string? _iconCss;
         private bool _transitionValue;
-        private ConditionType _transitionConditionType = ConditionType.Show;
+        private ConditionType _transitionConditionType = ConditionType.None;
 
         public bool Medium => false;
 
@@ -255,11 +255,16 @@ protected override void OnParametersSet()
                 _transitionValue = If;
                 _transitionConditionType = ConditionType.If;
             }
-            else
+            else if(IsDirtyParameter(nameof(TransitionShow)))
             {
                 _transitionValue = TransitionShow;
                 _transitionConditionType = ConditionType.Show;
             }
+            else
+            {
+                _transitionValue = true;
+                _transitionConditionType = ConditionType.None;
+            }
         }
 
         protected override async Task OnAfterRenderAsync(bool firstRender)

diff --git a/src/Masa.Blazor/Components/Transition/Elements/ConditionType.cs b/src/Masa.Blazor/Components/Transition/Elements/ConditionType.cs
@@ -2,6 +2,7 @@
 
 public enum ConditionType
 {
+    None,
     If,
     Show
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,7 @@ @@
     public enum ConditionType
     {
+        None,
         If,
         Show
     }