Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 'console.log(options)' #34

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rodw
Copy link

@rodw rodw commented Oct 31, 2020

Currently the complete options map is printed each time the CLI is invoked and there is no way to avoid that.

In certain usage patterns -- e.g. a Makefile that lints each file independently so we only need to lint the files that have changed -- this creates a lot of noise.

This PR just removes that single console.log line.

I'm guessing this is essentially debugging code that was never removed.

But if this is intentional and you want to keep the console.log can we at least add some kind of flag that would enable/disable this output?

Personally I'd make the don't-print-the-options-map the default setting and use --debug or whatever to turn this on when wanted, but something like --quiet or --dont-print-options or whatever would work fine too.

(If you really want I could create a PR for the flag-controlled version, it's pretty straightforward either way.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant